🐛 fix: improve semantics of combining cache selectorsByObject #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #1980, which introduced a regression in the way
cache.BuilderWithOptions
deals with scheme selection when handling selectors.When handling inherited selectors, we should only use the inherited scheme. However, when handling the selectors in the cache builder options, we should use the combined scheme. This ensures that callers are not forced to pass their parent
runtime.Scheme
down to everycache.BuilderWithOptions
call.#1980 has not yet been released, so this bug fix does not require any backport.